fix: XAccountController should use streaming in archiveBuild#384
Merged
fix: XAccountController should use streaming in archiveBuild#384
XAccountController should use streaming in archiveBuild#384Conversation
redshiftzero
force-pushed
the
383-large-archive
branch
from
0b36269 to
367cc79
Compare
redshiftzero
changed the title
XAccountController use streaming in archiveBuildXAccountController should use streaming in archiveBuild
micahflee
approved these changes
Jan 28, 2025
Member
micahflee
left a comment
micahflee
left a comment
There was a problem hiding this comment.
This looks like it should fix this specific problem to me. However, looking over this function (I'm the one who first wrote it) I can see how massive amounts of data combined with not much memory could cause it to crash in other ways too. I opened a future issue to deal with that: #385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #383
I've tested the
archiveBuildmethod using a small test archive